surface: Don't take a display argument in gdk_surface_new_popup()
authorBenjamin Otte <otte@redhat.com>
Fri, 21 Feb 2020 20:13:09 +0000 (21:13 +0100)
committerBenjamin Otte <otte@redhat.com>
Fri, 21 Feb 2020 20:13:09 +0000 (21:13 +0100)
The display can be taken from the surface, it must not be different.

gdk/gdksurface.c
gdk/gdksurface.h
gtk/gtkpopover.c
gtk/gtktooltipwindow.c

index 81edb5d44724c523a17221c1b2a914e05fd43d66..399e40c36890d1d9eb392ceeafe3184cf1e63801 100644 (file)
@@ -778,7 +778,6 @@ gdk_surface_new_temp (GdkDisplay         *display,
 
 /**
  * gdk_surface_new_popup: (constructor)
- * @display: the display to create the surface on
  * @parent: the parent surface to attach the surface to
  * @autohide: whether to hide the surface on outside clicks
  *
@@ -790,16 +789,14 @@ gdk_surface_new_temp (GdkDisplay         *display,
  * Returns: (transfer full): a new #GdkSurface
  */
 GdkSurface *
-gdk_surface_new_popup (GdkDisplay *display,
-                       GdkSurface *parent,
+gdk_surface_new_popup (GdkSurface *parent,
                        gboolean    autohide)
 {
   GdkSurface *surface;
 
-  g_return_val_if_fail (GDK_IS_DISPLAY (display), NULL);
   g_return_val_if_fail (GDK_IS_SURFACE (parent), NULL);
 
-  surface = gdk_surface_new (display, GDK_SURFACE_POPUP,
+  surface = gdk_surface_new (parent->display, GDK_SURFACE_POPUP,
                              parent, 0, 0, 100, 100);
 
   surface->autohide = autohide;
index 6f50e66b7b8f70476a4e5ea3de96a800a7fcd95b..1bf8b24eca75202e836e4425ae25231a2d6b9d45 100644 (file)
@@ -340,8 +340,7 @@ GdkSurface *   gdk_surface_new_toplevel         (GdkDisplay    *display,
                                                  int            width,
                                                  int            height);
 GDK_AVAILABLE_IN_ALL
-GdkSurface *   gdk_surface_new_popup            (GdkDisplay    *display,
-                                                 GdkSurface    *parent,
+GdkSurface *   gdk_surface_new_popup            (GdkSurface    *parent,
                                                  gboolean       autohide);
 
 GDK_AVAILABLE_IN_ALL
index c2e4d8ee232d7220774131d6a2263188ae4345c2..7c202414ee7194bb610232017df0b9918e3371c5 100644 (file)
@@ -743,13 +743,10 @@ gtk_popover_realize (GtkWidget *widget)
 {
   GtkPopover *popover = GTK_POPOVER (widget);
   GtkPopoverPrivate *priv = gtk_popover_get_instance_private (popover);
-  GdkDisplay *display;
   GdkSurface *parent;
 
-  display = gtk_widget_get_display (priv->relative_to);
-
   parent = gtk_native_get_surface (gtk_widget_get_native (priv->relative_to));
-  priv->surface = gdk_surface_new_popup (display, parent, priv->autohide);
+  priv->surface = gdk_surface_new_popup (parent, priv->autohide);
 
   gdk_surface_set_widget (priv->surface, widget);
 
index 73fc24e6257d84ed002bf68e630d3f753d59c6bd..4af7fc613d4df02c410de76c2a732a5b9c6a00e7 100644 (file)
@@ -229,13 +229,10 @@ static void
 gtk_tooltip_window_realize (GtkWidget *widget)
 {
   GtkTooltipWindow *window = GTK_TOOLTIP_WINDOW (widget);
-  GdkDisplay *display;
   GdkSurface *parent;
 
-  display = gtk_widget_get_display (window->relative_to);
-
   parent = gtk_native_get_surface (gtk_widget_get_native (window->relative_to));
-  window->surface = gdk_surface_new_popup (display, parent, FALSE);
+  window->surface = gdk_surface_new_popup (parent, FALSE);
 
   gdk_surface_set_widget (window->surface, widget);